Add single section dumping and output file padding to InstallRawStep#10267
Merged
andrewrk merged 1 commit intoziglang:masterfrom Dec 4, 2021
Merged
Add single section dumping and output file padding to InstallRawStep#10267andrewrk merged 1 commit intoziglang:masterfrom
andrewrk merged 1 commit intoziglang:masterfrom
Conversation
ikskuh
reviewed
Dec 3, 2021
Contributor
|
Part of your PR conflicts with my PR here #9975 Looks like we both had the same idea to add |
Contributor
Author
|
@marler8997 Oh wow our code looks really similar. That's a fun realization. Uh, I guess I could solve the merge conflict if your PR gets merged. Thanks for the heads up. |
Member
|
#9975 merged. Apologies to both of you for the delay on that one. |
Contributor
Author
|
Okay, I'll resolve the conflicts |
Member
|
Contributor
Author
|
Oh, sorry about that, merge conflict fail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the need for using tools like
objcopyto copy out a single section, andtruncateto pad binaries to the required size while building.